feat: add firestore v8 support#126
Merged
Merged
Conversation
Contributor
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
jy-tan
approved these changes
Mar 3, 2026
Contributor
jy-tan
left a comment
jy-tan
left a comment
There was a problem hiding this comment.
Remember to update version on README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends Firestore instrumentation to support
@google-cloud/firestorev8 in addition to the existing v7 support. Also adds trace/log volume mounts across all e2e docker-compose files for easier debugging.Changes
supportedVersionsinFirestoreInstrumentationfrom["7.*"]to["7.*", "8.*"]across the module and all patched files (document-reference, collection-reference, query)esm-firestoree2e test to pin@google-cloud/firestore@8.3.0to validate v8 compatibility.tusk/tracesand.tusk/logsvolume mounts to all e2edocker-compose.ymlfiles (26 files) to persist traces and logs on the host for easier debuggingNote
Medium Risk
Expands runtime patching to a new major Firestore version, which could surface incompatibilities if v8 internals diverge from v7. The docker-compose volume mount changes are low risk but affect local/CI e2e execution environments.
Overview
Extends Firestore instrumentation compatibility to
@google-cloud/firestore@8.xby wideningsupportedVersionsfrom v7-only to7.*and8.*(including the patcheddocument-reference,collection-reference, andqueryentrypoints).Updates the Firestore ESM e2e test to run against
@google-cloud/firestore@8.3.0, and modifies all library e2edocker-compose.ymlfiles to mount.tusk/tracesand.tusk/logsas host volumes for easier debugging. Also updates the README requirements list to reflect Firestore7.x-8.xsupport.Written by Cursor Bugbot for commit 9b5e52f. This will update automatically on new commits. Configure here.